Repository navigation
Conversation
A vowel pair is two different vowels. The phonology reference said so and the lexicon kept to it, but neither the word check nor the name check enforced the rule, so kaali passed as a productive name. Both checks now reject a vowel that follows itself. Canon records the ruling, with decision D120 in the development log. The phonology reference, the protocol checklists, the manual's chapter on hiatus, and the glossary state the rule.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the ruling of 19 November 2026: no Phi form doubles a vowel, and names are not an exception.
The phonology reference already defined a vowel pair as two distinct vowels, and no lexicon word has ever broken that. The validator did not enforce it.
python3 scripts/validate_examples.py name kaalireported a valid productive name, and theneighborscheck would have let a lexical candidate with a doubled vowel through as well.What changed
The word check in
validate_examples.pyand the name check inname_forms.pyeach reject a vowel that follows itself. The same two functions serve the lexicon, theneighborsandnamecommands, name atoms in documents, and the Tengwar renderer, so one rule covers all of them.test_name_forms.pygains a regression test for both checks. It also confirms that an ordinary pair such as the one inkaelistill passes.The ruling is recorded in
canon.mdbeside the three-syllable ceiling and as D120 in the development log. The phonology reference gets a section 3.3. The protocol's phonology checklist, hiatus step, and name-form checklist name the rule. The manual's chapter on hiatus teaches it in two sentences, and the glossary entry for phonotactics lists it.Wording to check
The canon bullet, the phonology reference, and the manual all give one reason for the rule: Phi has no long vowels, and two syllables of the same vowel with no onset between them would sound like one. That reason follows from the pronunciation ruling, which says no pair may become a single long vowel, but the wording here is new and the maintainer may prefer his own.
Effect on existing material
None. No lexicon word and no name anywhere in the texts, manual, primer, or pamphlets contains a doubled vowel, so nothing had to be renamed.
project/development_protocol.mdis also touched by #718, on a different line. The two changes do not overlap.Voice audit
The pass over the manual paragraph found one thing, after the first push: the sentence staged its example behind a colon ("No Phi word or name doubles a vowel: kaa would ask for..."). It is now two plain sentences, in a follow-up commit. The glossary clause and the reference text needed nothing.
Checks
Run locally on this branch, each as its own command:
python3 scripts/validate_examples.py: 1,305 entries, 0 errors, 0 warningspython3 scripts/validate_sentences.py: 3,313 examples, 0 errorspython3 scripts/test_sentence_validator.pyandpython3 scripts/test_name_forms.py: OKtest_vocabulary_schema.py,content_vocabulary_decisions.py --check,test_content_vocabulary_decisions.py,test_translation_layers.py,translation_process_status.py --check,test_translation_process_status.py,source_reconstruction.py,test_source_reconstruction.py: all exit 0python3 scripts/validate_sentences.py --docs: the same two diagnostics indocuments/evaluation/narrative_test_corpus.mdthat the handoff already records, and nothing newPer-file ledger
scripts/validate_examples.pyscripts/name_forms.pyscripts/test_name_forms.pycanon.mdproject/development_log.mddocuments/reference/phonology_rules.mdproject/development_protocol.mdmanual/part3_phonology/ch08_music_of_phi/01_the_golden_rule.mdmanual/appendices/appendix_a_glossary.md